Update configuration for the next cert-manager release 1.7#605
Update configuration for the next cert-manager release 1.7#605jetstack-bot merged 7 commits intocert-manager:masterfrom
Conversation
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
… release Signed-off-by: Richard Wall <richard.wall@jetstack.io>
config/jobs/cert-manager/release-previous/cert-manager-release-previous-periodics.yaml
Show resolved
Hide resolved
437d8ae to
4e00be3
Compare
…-next Signed-off-by: Richard Wall <richard.wall@jetstack.io>
4e00be3 to
bfbd4da
Compare
SgtCoDFish
left a comment
There was a problem hiding this comment.
A few questions and comments from me; I get the feeling I might've confused myself, so if I've said anything dumb please excuse me 😁
| - org: jetstack | ||
| repo: cert-manager | ||
| base_ref: release-1.6 | ||
| base_ref: release-1.7 |
There was a problem hiding this comment.
suggestion/question: I understand why this has been changed to release-1.7, and I'd be fine with it staying this way... but for at least the next few weeks, am I correct that these tests aren't going to do anything useful in practice, because we won't be updating the release-1.7 branch?
We could just comment out this whole config file basically until we do our first alpha for 1.7 and we'd lose nothing, I think. Periodics run against master do the "release-next" job until we create our first alpha.
(We've talked about wanting to do alphas more often, but we're not there yet and I'm thinking we could save some resources on our test cluster here)
Am I missing something? Could we, for now, not do any of these tests, or else maybe only run them every 2 days or every week rather than every 2 hours?
(I fully accept that this is a tangent to your PR here, and if you'd rather not have this discussion in this PR, then fair enough!)
There was a problem hiding this comment.
You're right. The release-1.7 branch will only ever be identical to, or behind master, so it's pointless to run these tests right now....but it's what we've always done so I propose not changing that in this PR.
We could create another PR to disable them
There was a problem hiding this comment.
but it's what we've always done so I propose not changing that in this PR.
Totally reasonable to leave it for a separate PR, yeah. I might raise that PR after this merges 👍
There was a problem hiding this comment.
Yeah I think in the past we have not created the release branch until we actually want to cut a release (i.e. just before the first alpha)
config/jobs/cert-manager/release-previous/cert-manager-release-previous-periodics.yaml
Show resolved
Hide resolved
config/jobs/cert-manager/release-previous/cert-manager-release-previous-presubmits.yaml
Show resolved
Hide resolved
config/jobs/cert-manager/release-previous/cert-manager-release-previous-presubmits.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
I can't see anything objectionable in here, let's do it
| - org: jetstack | ||
| repo: cert-manager | ||
| base_ref: release-1.6 | ||
| base_ref: release-1.7 |
There was a problem hiding this comment.
but it's what we've always done so I propose not changing that in this PR.
Totally reasonable to leave it for a separate PR, yeah. I might raise that PR after this merges 👍
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wallrj: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Based on changes in: