Skip to content

Update configuration for the next cert-manager release 1.7#605

Merged
jetstack-bot merged 7 commits intocert-manager:masterfrom
wallrj:cert-manager-1.6
Oct 29, 2021
Merged

Update configuration for the next cert-manager release 1.7#605
jetstack-bot merged 7 commits intocert-manager:masterfrom
wallrj:cert-manager-1.6

Conversation

@wallrj
Copy link
Member

@wallrj wallrj commented Oct 28, 2021

Based on changes in:

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
… release

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2021
@wallrj wallrj requested a review from munnerz October 28, 2021 14:24
…-next

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions and comments from me; I get the feeling I might've confused myself, so if I've said anything dumb please excuse me 😁

- org: jetstack
repo: cert-manager
base_ref: release-1.6
base_ref: release-1.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion/question: I understand why this has been changed to release-1.7, and I'd be fine with it staying this way... but for at least the next few weeks, am I correct that these tests aren't going to do anything useful in practice, because we won't be updating the release-1.7 branch?

We could just comment out this whole config file basically until we do our first alpha for 1.7 and we'd lose nothing, I think. Periodics run against master do the "release-next" job until we create our first alpha.

(We've talked about wanting to do alphas more often, but we're not there yet and I'm thinking we could save some resources on our test cluster here)

Am I missing something? Could we, for now, not do any of these tests, or else maybe only run them every 2 days or every week rather than every 2 hours?

(I fully accept that this is a tangent to your PR here, and if you'd rather not have this discussion in this PR, then fair enough!)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. The release-1.7 branch will only ever be identical to, or behind master, so it's pointless to run these tests right now....but it's what we've always done so I propose not changing that in this PR.
We could create another PR to disable them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it's what we've always done so I propose not changing that in this PR.

Totally reasonable to leave it for a separate PR, yeah. I might raise that PR after this merges 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think in the past we have not created the release branch until we actually want to cut a release (i.e. just before the first alpha)

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj wallrj requested a review from SgtCoDFish October 29, 2021 14:13
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I can't see anything objectionable in here, let's do it

- org: jetstack
repo: cert-manager
base_ref: release-1.6
base_ref: release-1.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it's what we've always done so I propose not changing that in this PR.

Totally reasonable to leave it for a separate PR, yeah. I might raise that PR after this merges 👍

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit b1e18f4 into cert-manager:master Oct 29, 2021
@jetstack-bot
Copy link
Contributor

@wallrj: Updated the following 2 configmaps:

  • plugins configmap in namespace default at cluster default using the following files:
    • key plugins.yaml using file config/plugins.yaml
  • job-config configmap in namespace default at cluster default using the following files:
    • key cert-manager-presubmits.yaml using file config/jobs/cert-manager/cert-manager-presubmits.yaml
    • key cert-manager-release-next-periodics.yaml using file config/jobs/cert-manager/release-next/cert-manager-release-next-periodics.yaml
    • key cert-manager-release-previous-periodics.yaml using file config/jobs/cert-manager/release-previous/cert-manager-release-previous-periodics.yaml
    • key cert-manager-release-previous-presubmits.yaml using file config/jobs/cert-manager/release-previous/cert-manager-release-previous-presubmits.yaml
Details

In response to this:

Based on changes in:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants